Github user pwendell commented on the pull request:

    https://github.com/apache/spark/pull/3913#issuecomment-98071817
  
    I'm good with the new idea you proposed. We keep `util.SizeEstimator` as 
is, but we have a public class in the root namespace `SizeEstimator` that just 
has a single method that calls into the internal one. We can always merge them 
together later if we want too, but IMO it's worth keeping the larger 
implementation totally private.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to