otterc commented on a change in pull request #32140: URL: https://github.com/apache/spark/pull/32140#discussion_r645880908
########## File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/FetchShuffleBlockChunks.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.shuffle.protocol; + +import java.util.Arrays; + +import io.netty.buffer.ByteBuf; + +import org.apache.spark.network.protocol.Encoders; + +// Needed by ScalaDoc. See SPARK-7726 +import static org.apache.spark.network.shuffle.protocol.BlockTransferMessage.Type; + + +/** + * Request to read a set of block chunks. Returns {@link StreamHandle}. + * + * @since 3.2.0 + */ +public class FetchShuffleBlockChunks extends AbstractFetchShuffleBlocks { + // The length of reduceIds must equal to chunkIds.size(). Review comment: This is a strong assumption. For a `reduceIds[i]`, each chunkId in chunksIds[i] represents a shuffleChunk `shuffleChunk_<shuffleId>_reduceIds[i]_chunksIds[i][j]` which is being requested. This is similar to the existing FetchShuffleBlock message. There are assertions on the server side as well to check this. > Do we see a future evolution where this can break Not really. At least I can't think of any that would change this. This just represents all the chunkIds for a particular reduceIds that are being requested which I don't think will change. > encode and decode do not assume this currently That's right. I can avoid writing `chunkIdsLen`. It is just that I mimicked the code in `FetchShuffleBlocks` which does the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
