otterc commented on a change in pull request #32140:
URL: https://github.com/apache/spark/pull/32140#discussion_r645895089
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockId.scala
##########
@@ -124,11 +134,12 @@ class UnrecognizedBlockId(name: String)
@DeveloperApi
object BlockId {
val RDD = "rdd_([0-9]+)_([0-9]+)".r
- val SHUFFLE = "shuffle_([0-9]+)_([0-9]+)_([0-9]+)".r
+ val SHUFFLE = "shuffle_([0-9]+)_(-?[0-9]+)_([0-9]+)".r
Review comment:
This is to support a merged map id which has `-1` as mapId. Is the
suggestion to replace `-?` with `\\d+`? That doesn't work or maybe I
misunderstood.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
