HyukjinKwon commented on a change in pull request #32410:
URL: https://github.com/apache/spark/pull/32410#discussion_r648786800
##########
File path:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
##########
@@ -141,7 +141,8 @@ public void open(Map<String, String> sessionConfMap) throws
HiveSQLException {
sessionState = new SessionState(hiveConf, username);
sessionState.setUserIpAddress(ipAddress);
sessionState.setIsHiveServerQuery(true);
- SessionState.start(sessionState);
+ // Use setCurrentSessionState to avoid creating useless SessionDirs.
+ SessionState.setCurrentSessionState(sessionState);
Review comment:
Hm, actually @wangyum. I just noticed that this is different from Hive's
https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java#L180.
Shouldn't we at least keep:
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L692-L699
for session history?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
