HyukjinKwon commented on a change in pull request #32410:
URL: https://github.com/apache/spark/pull/32410#discussion_r649958997
##########
File path:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImpl.java
##########
@@ -141,7 +141,8 @@ public void open(Map<String, String> sessionConfMap) throws
HiveSQLException {
sessionState = new SessionState(hiveConf, username);
sessionState.setUserIpAddress(ipAddress);
sessionState.setIsHiveServerQuery(true);
- SessionState.start(sessionState);
+ // Use setCurrentSessionState to avoid creating useless SessionDirs.
+ SessionState.setCurrentSessionState(sessionState);
Review comment:
@wangyum, last question. What about this? Is it safe to remove?
```
// Hive object instance should be created with a copy of the conf
object. If the conf is
// shared with SessionState, other parts of the code might update the
config, but
// Hive.get(HiveConf) would not recognize the case when it needs
refreshing
Hive.get(new HiveConf(startSs.conf)).getMSC();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
