tomvanbussel commented on a change in pull request #33108: URL: https://github.com/apache/spark/pull/33108#discussion_r659553215
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnVectorSuite.scala ########## @@ -243,6 +243,93 @@ class ColumnVectorSuite extends SparkFunSuite with BeforeAndAfterEach { assert(testVector.getArray(3).toIntArray() === Array(3, 4, 5)) } + testVectors("array append", 1, arrayType) { testVector => Review comment: Sure, I will add them! I did not add before them since they test general usage patterns instead of a specific edge case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org