cloud-fan commented on a change in pull request #33108: URL: https://github.com/apache/spark/pull/33108#discussion_r660240374
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/Columnar.scala ########## @@ -264,12 +264,12 @@ private object RowToColumnConverter { case DoubleType => DoubleConverter case StringType => StringConverter case CalendarIntervalType => CalendarConverter - case at: ArrayType => new ArrayConverter(getConverterForType(at.elementType, nullable)) + case at: ArrayType => ArrayConverter(getConverterForType(at.elementType, at.containsNull)) case st: StructType => new StructConverter(st.fields.map( (f) => getConverterForType(f.dataType, f.nullable))) case dt: DecimalType => new DecimalConverter(dt) - case mt: MapType => new MapConverter(getConverterForType(mt.keyType, nullable), - getConverterForType(mt.valueType, nullable)) + case mt: MapType => MapConverter(getConverterForType(mt.keyType, nullable = false), + getConverterForType(mt.valueType, mt.valueContainsNull)) Review comment: if the map itself is null, I think we won't invoke the converter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org