MaxGekk commented on a change in pull request #33280:
URL: https://github.com/apache/spark/pull/33280#discussion_r667443599
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1008,17 +1008,17 @@ case class UnixTimestamp(
copy(timeExp = newLeft, format = newRight)
}
-case class GetTimestampNTZ(
+/**
+ * Gets timestamps or dates from strings.
Review comment:
Gets a timestamp from a string or a date (or a timestamp?). See
`inputTypes` in the parent class.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1909,7 +1909,8 @@ case class ParseToDate(left: Expression, format:
Option[Expression], child: Expr
usage = """
_FUNC_(timestamp_str[, fmt]) - Parses the `timestamp_str` expression with
the `fmt` expression
to a timestamp. Returns null with invalid input. By default, it follows
casting rules to
- a timestamp if the `fmt` is omitted.
+ a timestamp if the `fmt` is omitted. The result data type is consistent
with the value of
+ configuration `spark.sql.timestampType`.
Review comment:
Use TIMESTAMP_TYPE.key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
