gengliangwang commented on a change in pull request #33280: URL: https://github.com/apache/spark/pull/33280#discussion_r667473505
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ########## @@ -1008,17 +1008,17 @@ case class UnixTimestamp( copy(timeExp = newLeft, format = newRight) } -case class GetTimestampNTZ( +/** + * Gets timestamps or dates from strings. Review comment: The expression here are quite messy. But I think if there are two children, it should be of (string, string) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org