Shockang commented on a change in pull request #33317: URL: https://github.com/apache/spark/pull/33317#discussion_r671090866
########## File path: core/src/main/scala/org/apache/spark/errors/ExecutionErrors.scala ########## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.errors + +import java.io.IOException + +import org.apache.hadoop.fs.Path + +import org.apache.spark.SparkException +import org.apache.spark.storage.{BlockId, RDDBlockId} + +/** + * Object for grouping error messages from (most) exceptions thrown during query execution. + * This does not include exceptions thrown during the eager execution of commands, which are + * grouped into [[CompilationErrors]]. + */ +private[spark] object ExecutionErrors { + def blockOfRddNotFoundError(blockId: BlockId, id: Int): Throwable = { + new Exception(s"Could not compute split, block $blockId of RDD $id not found") + } + + def blockHaveBeenRemovedError(): Throwable = { + new SparkException("Attempted to use %s after its blocks have been removed!".format(toString)) Review comment: A parameterless method is a function that does not take parameters, defined by the absence of any empty parenthesis. Invocation of a paramaterless function should be done without parenthesis. This enables the change of def to val without any change in the client code which is a part of uniform access principle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org