cloud-fan commented on a change in pull request #33650:
URL: https://github.com/apache/spark/pull/33650#discussion_r691776887
##########
File path:
external/avro/src/main/scala/org/apache/spark/sql/v2/avro/AvroScanBuilder.scala
##########
@@ -41,17 +42,16 @@ class AvroScanBuilder (
readDataSchema(),
readPartitionSchema(),
options,
- pushedFilters())
+ pushedDataFilters,
+ partitionFilters,
+ dataFilters)
}
- private var _pushedFilters: Array[Filter] = Array.empty
-
- override def pushFilters(filters: Array[Filter]): Array[Filter] = {
+ override def pushDataFilters(dataFilters: Seq[Expression]): Array[Filter] = {
Review comment:
nit: the input parameter can be `dataFilters: Array[Filter]`, then we
don't need to ask every source impl to call `translateDataFilter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
