cloud-fan commented on a change in pull request #33650: URL: https://github.com/apache/spark/pull/33650#discussion_r692343780
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala ########## @@ -57,6 +64,29 @@ abstract class FileScanBuilder( StructType(fields) } + def pushFilters(partitionFilters: Seq[Expression], dataFilters: Seq[Expression]): Unit = { + + def translateDataFilter(): Array[Filter] = { Review comment: let's truly inline it ``` this.partitionFilters = partitionFilters this.dataFilters = dataFilters val translatedDataFilters = mutable.ArrayBuffer.empty[sources.Filter] for ... this.pushedDataFilters = pushDataFilters(translateDataFilter) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org