viirya commented on pull request #33650: URL: https://github.com/apache/spark/pull/33650#issuecomment-902856349
Some description looks ambiguous. E.g., > add pushFilters in file source v2. In this method... As you are adding a method to a class. It is better to use the exact class name so it is clearly to read and trace. "file source v2" -> FileScanBuilder I feel that "file source" or "file source v2" is ambiguous word. I'd prefer to write clearly in the description. > Currently in V2ScanRelationPushDown, we push the filters (partition filters + data filters) to file source "file source" -> FileScanBuilder or FileScan or file source scan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
