viirya commented on pull request #33650: URL: https://github.com/apache/spark/pull/33650#issuecomment-904390563
Seems okay, just one possible concern. I recall that we usually keep to hide catalyst (expressions, query plan...) from DataSource V2 API and implementation. So the internal API can be decoupled with external API (v2, for example). This `SupportsPushDownCatalystFilters` looks like to break this convention. But besides that, I don't have better idea. If this is only for limited API (e.g. file source v2), sounds like it isn't severe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
