venkata91 commented on a change in pull request #33896: URL: https://github.com/apache/spark/pull/33896#discussion_r741551702
########## File path: core/src/main/scala/org/apache/spark/Dependency.scala ########## @@ -131,7 +135,7 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C: ClassTag]( def shuffleMergeId: Int = _shuffleMergeId def setMergerLocs(mergerLocs: Seq[BlockManagerId]): Unit = { - if (mergerLocs != null) { + if (mergerLocs != null && mergerLocs.nonEmpty) { Review comment: Most likely difference in the code from the internal and the OSS version. Yes you're right, I don't think we need to check again here for `nonEmpty` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org