[GitHub] [spark] imback82 commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

[GitBox]

imback82 commented on a change in pull request #34686:
URL: https://github.com/apache/spark/pull/34686#discussion_r755721667



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -349,7 +351,7 @@ case class SetNamespaceProperties(
  */
 case class SetNamespaceLocation(
     namespace: LogicalPlan,
-    location: String) extends UnaryCommand {
+    location: URI) extends UnaryCommand {

Review comment:
       Thanks for catching this. This is where qualified path is generated for 
v1 catalog (happening in the catalog not in the command): 
https://github.com/apache/spark/blob/c1029dcff103b1044a55b728c6c98113a255de1e/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala#L285




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org