[GitHub] [spark] cloud-fan commented on a change in pull request #34686: [SPARK-37444][SQL] ALTER NAMESPACE ... SET LOCATION should handle empty location consistently across v1 and v2 command

[GitBox]

cloud-fan commented on a change in pull request #34686:
URL: https://github.com/apache/spark/pull/34686#discussion_r755790090



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -44,7 +45,8 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap
 import org.apache.spark.storage.StorageLevel
 import org.apache.spark.unsafe.types.UTF8String
 
-class DataSourceV2Strategy(session: SparkSession) extends Strategy with 
PredicateHelper {
+class DataSourceV2Strategy(session: SparkSession) extends Strategy
+    with PredicateHelper with SQLConfHelper {

Review comment:
       We don't need `SQLConfHelper`. We can get the conf by 
`session.sessionState.conf`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org