Peng-Lei commented on a change in pull request #35131:
URL: https://github.com/apache/spark/pull/35131#discussion_r780390548
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/V1Table.scala
##########
@@ -55,7 +56,8 @@ private[sql] case class V1Table(v1Table: CatalogTable)
extends Table {
}
}
- override lazy val properties: util.Map[String, String] =
v1Table.properties.asJava
+ override lazy val properties: util.Map[String, String] =
+ V1Table.filterTableProperties(v1Table).asJava
Review comment:
Thank you very much. I try do it. In fact, officially because store
these v2 table properties into metastore when create table, I spent a lot of
time looking for failed use cases and trying to fix. It is indeed a breaking
change to generate v2 properties when creating tables and store them. Thank you
for your reminder very much. @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
