cloud-fan commented on a change in pull request #35131: URL: https://github.com/apache/spark/pull/35131#discussion_r781153844
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalogSuite.scala ########## @@ -253,16 +255,14 @@ class V2SessionCatalogTableSuite extends V2SessionCatalogBaseSuite { val catalog = newCatalog() val table = catalog.createTable(testIdent, schema, Array.empty, emptyProps) + val loaded = catalog.loadTable(testIdent) - assert(table.properties.asScala == Map()) + assert(table.properties == loaded.properties) val updated = catalog.alterTable(testIdent, TableChange.setProperty("prop-1", "1")) - assert(updated.properties.asScala == Map("prop-1" -> "1")) Review comment: ditto, can we keep this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org