maryannxue commented on code in PR #36238:
URL: https://github.com/apache/spark/pull/36238#discussion_r852445678
##########
core/src/main/scala/org/apache/spark/executor/Executor.scala:
##########
@@ -296,6 +332,8 @@ private[spark] class Executor(
} else {
taskRunner.kill(interruptThread = interruptThread, reason = reason)
}
+ // Safe to remove kill mark as we got a chance with the TaskRunner.
+ killMarks.remove(taskId)
Review Comment:
You need try/finally for a `ConcurrentHashMap.remove` operation??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
