mridulm commented on code in PR #36238: URL: https://github.com/apache/spark/pull/36238#discussion_r853307917
########## core/src/main/scala/org/apache/spark/executor/Executor.scala: ########## @@ -264,16 +290,26 @@ private[spark] class Executor( decommissioned = true } + private[executor] def createTaskRunner(context: ExecutorBackend, + taskDescription: TaskDescription) = new TaskRunner(context, taskDescription, plugins) + def launchTask(context: ExecutorBackend, taskDescription: TaskDescription): Unit = { - val tr = new TaskRunner(context, taskDescription, plugins) - runningTasks.put(taskDescription.taskId, tr) + val taskId = taskDescription.taskId + val tr = createTaskRunner(context, taskDescription) + runningTasks.put(taskId, tr) + val killMark = killMarks.get(taskId) + if (killMark != null) { + tr.kill(killMark._1, killMark._2) + killMarks.remove(taskId) + } threadPool.execute(tr) Review Comment: In this context, we know it is going to immediately fail when the task starts - and there is a bunch of things which happen before that check and after here. I am fine with adding this as a TODO if you feel strongly about keeping the current path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org