cloud-fan commented on code in PR #32298: URL: https://github.com/apache/spark/pull/32298#discussion_r853084454
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -1014,6 +1018,24 @@ case class Aggregate( } } +object Aggregate { + def supportsAggregationBufferSchema(schema: StructType): Boolean = { Review Comment: This function name looks confusing. How about `isAggregateBufferMutable`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org