cloud-fan commented on code in PR #32298: URL: https://github.com/apache/spark/pull/32298#discussion_r853713177
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ########## @@ -663,11 +663,13 @@ case class UnresolvedWith( * predicates that have been pushed down into `child`. This is * a temporary field used by optimization rules for CTE predicate * pushdown to help ensure rule idempotency. + * @param mergedScalarSubquery If this definition is a merged scalar subquery. Review Comment: I think it's better to clarify what this flag means to CTE relation, instead of linking to another feature. how about ``` @param underSubquery If true, it means we don't need to add a shuffle for this CTE relation as subquery reuse will kick in. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
