cloud-fan commented on code in PR #36330:
URL: https://github.com/apache/spark/pull/36330#discussion_r859457664
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/util/V2ExpressionSQLBuilder.java:
##########
@@ -228,4 +241,37 @@ protected String visitSQLFunction(String funcName,
String[] inputs) {
protected String visitUnexpectedExpr(Expression expr) throws
IllegalArgumentException {
throw new IllegalArgumentException("Unexpected V2 expression: " + expr);
}
+
+ protected String visitOverlay(String funcName, String[] inputs) {
Review Comment:
can we add some `if-else` in `visitSQLFunction` to deal with these special
syntax? Then we don't need to keep adding new functions to this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
