cloud-fan commented on code in PR #36265:
URL: https://github.com/apache/spark/pull/36265#discussion_r866856072
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala:
##########
@@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager:
CatalogManager)
case Sort(sortOrder, global, agg: Aggregate) if agg.resolved =>
// We should resolve the references normally based on child
(agg.output) first.
- val maybeResolved =
sortOrder.map(_.child).map(resolveExpressionByPlanOutput(_, agg))
Review Comment:
I think this bug is much more complicated. Think about `order by sum(id)`
and `order by abs(id)`. For the first case, we want to resolve `id` to the
table column and push `sum(id)` to the Aggregate. For the second case, we want
to resolve `id` to `sum(id) as id`.
How to define a clear rule here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
