cloud-fan commented on code in PR #36265: URL: https://github.com/apache/spark/pull/36265#discussion_r866863003
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -2563,7 +2563,23 @@ class Analyzer(override val catalogManager: CatalogManager) case Sort(sortOrder, global, agg: Aggregate) if agg.resolved => // We should resolve the references normally based on child (agg.output) first. - val maybeResolved = sortOrder.map(_.child).map(resolveExpressionByPlanOutput(_, agg)) Review Comment: e.g. ``` val maybeResolved = sortOrder.map(_.child).map { expr => val resolved = resolveTemp(expr, agg) if (resolved.exists(_.isInstanceOf[AggregateFunction])) { unresolve(resolved) } else { resolved } } resolveOperatorWithAggregate... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org