Yikun commented on code in PR #36599:
URL: https://github.com/apache/spark/pull/36599#discussion_r876936498
##########
python/pyspark/pandas/series.py:
##########
@@ -6239,13 +6239,19 @@ def argsort(self) -> "Series":
ps.concat([psser, self.loc[self.isnull()].spark.transform(lambda
_: SF.lit(-1))]),
)
- def argmax(self) -> int:
+ def argmax(self, skipna: bool = True) -> int:
Review Comment:
```suggestion
def argmax(self, axis: Axis = None, skipna: bool = True) -> int:
```
We'd better to keep the pandas behaviors even if the `axis` is a
dummy(placeholder) parameter.
[1]
https://pandas.pydata.org/docs/reference/api/pandas.Series.argmax.html#pandas.Series.argmax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
