[GitHub] [spark] Yikun commented on a diff in pull request #36599: [SPARK-39228][PYTHON][PS] Implement `skipna` of `Series.argmax`

[GitBox]

Yikun commented on code in PR #36599:
URL: https://github.com/apache/spark/pull/36599#discussion_r877669800


##########
python/pyspark/pandas/series.py:
##########
@@ -6239,13 +6239,19 @@ def argsort(self) -> "Series":
             ps.concat([psser, self.loc[self.isnull()].spark.transform(lambda 
_: SF.lit(-1))]),
         )
 
-    def argmax(self) -> int:
+    def argmax(self, skipna: bool = True) -> int:

Review Comment:
   
![image](https://user-images.githubusercontent.com/1736354/169432658-ab51f8eb-2014-4d6b-b95d-67e78e077029.png)
   
   It would be listed.
   
   ```python
   >>> from inspect import signature
   >>> signature(pd.Series.argmax).parameters
   mappingproxy(OrderedDict([('self', <Parameter "self">), ('axis', <Parameter 
"axis=None">), ('skipna', <Parameter "skipna: 'bool' = True">), ('args', 
<Parameter "*args">), ('kwargs', <Parameter "**kwargs">)]))
   >>> signature(ps.Series.argmax).parameters
   mappingproxy(OrderedDict([('self', <Parameter "self">), ('skipna', 
<Parameter "skipna: bool = True">)]))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org