otterc commented on code in PR #36601:
URL: https://github.com/apache/spark/pull/36601#discussion_r877329983
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -1885,6 +1885,14 @@ private[spark] class DAGScheduler(
mapOutputTracker.
unregisterMergeResult(shuffleId, reduceId, bmAddress,
Option(mapIndex))
}
+ } else {
+ // Unregister the merge result of <shuffleId, reduceId> if
+ // the FetchFailed event contains a mapIndex of -1, and is not a
+ // MetaDataFetchException which is signified by bmAddress being
null
+ if (bmAddress != null && pushBasedShuffleEnabled) {
Review Comment:
I think we should check for `pushBasedShuffleEnabled` here just for
consistency with lines 1882-1886. There aren't going to be any merge results if
push-based shuffle is not enabled but since we do it at the other places we
should do it here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
