[GitHub] [spark] otterc commented on a diff in pull request #36601: [SPARK-38987][SHUFFLE] Throw FetchFailedException when merged shuffle blocks are corrupted and spark.shuffle.detectCorrupt is set to true

[GitBox]

otterc commented on code in PR #36601:
URL: https://github.com/apache/spark/pull/36601#discussion_r877366840


##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -1885,6 +1885,14 @@ private[spark] class DAGScheduler(
               mapOutputTracker.
                 unregisterMergeResult(shuffleId, reduceId, bmAddress, 
Option(mapIndex))
             }
+          } else {
+            // Unregister the merge result of <shuffleId, reduceId> if
+            // there is a FetchFailed event and is not a
+            // MetaDataFetchException which is signified by bmAddress being 
null
+            if (bmAddress != null) {
+              mapOutputTracker.
+                unregisterMergeResult(shuffleId, reduceId, bmAddress, None)
+            }

Review Comment:
   Can you also check line 2031 where `removeExecutorAndUnregisterOutputs` is 
called. The `executorId` for ShuffleMergedChunk is `shuffle-push-merger`. Will 
that cause any issues? We should probably add a UT for this as well with the 
`unRegisterOutputOnHostOnFetchFailure` enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org