[GitHub] [spark] mridulm commented on a diff in pull request #36601: [SPARK-38987][SHUFFLE] Throw FetchFailedException when merged shuffle blocks are corrupted and spark.shuffle.detectCorrupt is set to true

[GitBox]

mridulm commented on code in PR #36601:
URL: https://github.com/apache/spark/pull/36601#discussion_r882292810


##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -2461,6 +2474,8 @@ private[spark] class DAGScheduler(
       clearCacheLocs()
     }

Review Comment:
   We need to `removeShufflePushMergerLocation` even when `execId == 
SHUFFLE_MERGER_IDENTIFIER` (makes sense for rest of the `if` block to be within 
 `! isShuffleMerger` check; namely updating `executorFailureEpoch`, 
`removeExecutor` and `clearCacheLocs`)
   
   Looks like we dont have a test to verify `removeShufflePushMergerLocation` 
is called ?
   If not, we should add one.  +CC @otterc 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org