cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r885787249
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala:
##########
@@ -232,3 +216,36 @@ case class CheckOverflowInSum(
override protected def withNewChildInternal(newChild: Expression):
CheckOverflowInSum =
copy(child = newChild)
}
+
+/**
+ * An add expression which is only used internally by Sum/Avg.
+ *
+ * Nota that, this expression does not check overflow which is different with
`Add`.
+ */
+case class DecimalAddNoOverflowCheck(
+ left: Expression,
+ right: Expression,
+ override val dataType: DataType,
+ failOnError: Boolean = SQLConf.get.ansiEnabled)
+ extends BinaryArithmetic with DecimalArithmeticSupport {
Review Comment:
why do we need to extend `DecimalArithmeticSupport` here? It doesn't seem
like we can reuse many code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
