ulysses-you commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r886781843
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ########## @@ -490,12 +622,27 @@ trait DivModLike extends BinaryArithmetic { s"${eval2.value} == 0" } val javaType = CodeGenerator.javaType(dataType) + val errorContext = if (nullOnOverflow) { + "\"\"" + } else { + ctx.addReferenceObj("errCtx", queryContext) + } val operation = if (operandsDataType.isInstanceOf[DecimalType]) { - decimalToDataTypeCodeGen(s"${eval1.value}.$decimalMethod(${eval2.value})") + val decimal = super.dataType.asInstanceOf[DecimalType] Review Comment: afraid not.. we should use its precision and scale to change precision -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org