LuciferYang commented on code in PR #36774:
URL: https://github.com/apache/spark/pull/36774#discussion_r890285150
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala:
##########
@@ -153,10 +152,9 @@ class OrcFileFormat
} else {
// ORC predicate pushdown
if (orcFilterPushDown && filters.nonEmpty) {
- OrcUtils.readCatalystSchema(filePath, conf,
ignoreCorruptFiles).foreach { fileSchema =>
Review Comment:
Thanks for your review @beliefer , you are right,
`OrcUtils.readCatalystSchema` catch the `FileFormatException`. But if
`OrcUtils.readCatalystSchema` catches an `FileFormatException`, it should have
been thrown on line 147.
https://github.com/apache/spark/blob/18ca369f01905b421a658144e23b5a4e60702655/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala#L146-L161
https://github.com/apache/spark/blob/18ca369f01905b421a658144e23b5a4e60702655/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcUtils.scala#L72-L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
