LuciferYang commented on code in PR #36774:
URL: https://github.com/apache/spark/pull/36774#discussion_r890306149
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala:
##########
@@ -153,10 +152,9 @@ class OrcFileFormat
} else {
// ORC predicate pushdown
if (orcFilterPushDown && filters.nonEmpty) {
- OrcUtils.readCatalystSchema(filePath, conf,
ignoreCorruptFiles).foreach { fileSchema =>
Review Comment:
And should we change to use `OrcUtils.readSchema(filePath, conf,
ignoreCorruptFiles)` at line 147 in `OrcFileFormat`, then it seems that the
`FileFormatException ` is handled in `OrcFileFormat`, otherwise, the
`FileFormatException ` will be thrown and handled by `FileScanRDD.` Am I
right?
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
