[GitHub] [spark] cloud-fan commented on a diff in pull request #36812: [SPARK-39419][SQL] Fix ArraySort to throw an exception when the comparator returns null

[GitBox]

cloud-fan commented on code in PR #36812:
URL: https://github.com/apache/spark/pull/36812#discussion_r892990862


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2012,4 +2012,12 @@ private[sql] object QueryExecutionErrors extends 
QueryErrorsBase {
     new SparkException(
       errorClass = "MULTI_VALUE_SUBQUERY_ERROR", messageParameters = 
Array(plan), cause = null)
   }
+
+  def comparisonResultIsNullError(): Throwable = {
+    new NullPointerException(

Review Comment:
   yea, with the new error class framework, the java exception type doesn't 
matter any more. We can always use `SparkException`, but we need to add an 
error class for it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org