gengliangwang commented on code in PR #36812:
URL: https://github.com/apache/spark/pull/36812#discussion_r893036298
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -3828,6 +3828,15 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_ARRAY_SORT_FAILS_ON_NULL_COMPARISON_RESULT =
+ buildConf("spark.sql.legacy.arraySortFailsOnNullComparisonResult")
Review Comment:
I feel the "fail" behavior is the legacy one from the new conf name. The
previous name was good. Or we can follow the other conf style
`spark.sql.legacy.allowNullComparisonResultInArraySort`.
Sorry about the previous trivial comment:
https://github.com/apache/spark/pull/36812#discussion_r892996318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
