cloud-fan commented on code in PR #36698: URL: https://github.com/apache/spark/pull/36698#discussion_r893003240
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala: ########## @@ -953,15 +952,16 @@ case class Pmod( // when we reach here, failOnError must bet true. throw QueryExecutionErrors.divideByZeroError(queryContext) } - input1 match { - case i: Integer => pmod(i, input2.asInstanceOf[java.lang.Integer]) - case l: Long => pmod(l, input2.asInstanceOf[java.lang.Long]) - case s: Short => pmod(s, input2.asInstanceOf[java.lang.Short]) - case b: Byte => pmod(b, input2.asInstanceOf[java.lang.Byte]) - case f: Float => pmod(f, input2.asInstanceOf[java.lang.Float]) - case d: Double => pmod(d, input2.asInstanceOf[java.lang.Double]) - case d: Decimal => checkOverflow( - pmod(d, input2.asInstanceOf[Decimal]), dataType.asInstanceOf[DecimalType]) + + dataType match { Review Comment: we should cache it somewhere, otherwise it's very expensive to call it per row. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org