cloud-fan commented on code in PR #36698:
URL: https://github.com/apache/spark/pull/36698#discussion_r893017456
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -734,11 +920,35 @@ case class Pmod(
override def nullable: Boolean = true
+ override def decimalMethod: String = "remainder"
+
+ // This follows Remainder rule
+ override def resultDecimalType(p1: Int, s1: Int, p2: Int, s2: Int):
DecimalType = {
+ val resultScale = max(s1, s2)
+ val resultPrecision = min(p1 - s1, p2 - s2) + resultScale
+ if (allowPrecisionLoss) {
+ DecimalType.adjustPrecisionScale(resultPrecision, resultScale)
+ } else {
+ DecimalType.bounded(resultPrecision, resultScale)
+ }
+ }
+
private lazy val isZero: Any => Boolean = right.dataType match {
case _: DecimalType => x => x.asInstanceOf[Decimal].isZero
case _ => x => x == 0
}
+ private lazy val pmodCache: (Any, Any) => Any = (l, r) => dataType match {
Review Comment:
this doesn't work... we should do
```
dataType match {
case _: IntegerType => (l, r) => ...
...
}
```
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala:
##########
@@ -734,11 +920,35 @@ case class Pmod(
override def nullable: Boolean = true
+ override def decimalMethod: String = "remainder"
+
+ // This follows Remainder rule
+ override def resultDecimalType(p1: Int, s1: Int, p2: Int, s2: Int):
DecimalType = {
+ val resultScale = max(s1, s2)
+ val resultPrecision = min(p1 - s1, p2 - s2) + resultScale
+ if (allowPrecisionLoss) {
+ DecimalType.adjustPrecisionScale(resultPrecision, resultScale)
+ } else {
+ DecimalType.bounded(resultPrecision, resultScale)
+ }
+ }
+
private lazy val isZero: Any => Boolean = right.dataType match {
case _: DecimalType => x => x.asInstanceOf[Decimal].isZero
case _ => x => x == 0
}
+ private lazy val pmodCache: (Any, Any) => Any = (l, r) => dataType match {
Review Comment:
```suggestion
private lazy val pmodFunc: (Any, Any) => Any = (l, r) => dataType match {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
