amaliujia commented on code in PR #36904: URL: https://github.com/apache/spark/pull/36904#discussion_r904112358
########## sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala: ########## @@ -26,6 +26,22 @@ import org.apache.spark.sql.catalyst.DefinedByConstructorParams // Note: all classes here are expected to be wrapped in Datasets and so must extend // DefinedByConstructorParams for the catalog to be able to create encoders for them. +/** + * A catalog in Spark, as returned by the `listCatalogs` method defined in [[Catalog]]. + * + * @param name name of the catalog + * @since 3.2.0 + */ +class CatalogMetadata( + val name: String) Review Comment: Sounds good for keeping the class and additionally adding a description field. Regrading renaming to `Catalog`, it will have a naming conflict with https://github.com/apache/spark/blob/59eee98024dac42309f2e7196c7e68832317f284/sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala#L33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
