HyukjinKwon commented on code in PR #36904:
URL: https://github.com/apache/spark/pull/36904#discussion_r904452603
##########
sql/core/src/main/scala/org/apache/spark/sql/catalog/Catalog.scala:
##########
@@ -589,4 +589,25 @@ abstract class Catalog {
* @since 2.0.0
*/
def refreshByPath(path: String): Unit
+
+ /**
+ * Returns the current default catalog in this session.
+ *
+ * @since 3.4.0
+ */
+ def currentCatalog(): String
Review Comment:
Would need to 1. have a default implementation for backward compatibility,
or 2. exclude this from binary compatibility check.
The real error is:
```
[error] spark-sql: Failed binary compatibility check against
org.apache.spark:spark-sql_2.12:3.2.0! Found 3 potential problems (filtered 602)
[error] * abstract method currentCatalog()java.lang.String in class
org.apache.spark.sql.catalog.Catalog is present only in current version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.currentCatalog")
[error] * abstract method setCurrentCatalog(java.lang.String)Unit in class
org.apache.spark.sql.catalog.Catalog is present only in current version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.setCurrentCatalog")
[error] * abstract method listCatalogs()org.apache.spark.sql.Dataset in
class org.apache.spark.sql.catalog.Catalog is present only in current version
[error] filter with:
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.sql.catalog.Catalog.listCatalogs")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
