LuciferYang commented on code in PR #37876: URL: https://github.com/apache/spark/pull/37876#discussion_r971423880
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala: ########## @@ -129,20 +131,19 @@ object ArrayBasedMapData { def toScalaMap(map: ArrayBasedMapData): Map[Any, Any] = { val keys = map.keyArray.asInstanceOf[GenericArrayData].array val values = map.valueArray.asInstanceOf[GenericArrayData].array - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: Array[Any], values: Array[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: scala.collection.Seq[Any], values: scala.collection.Seq[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toJavaMap(keys: Array[Any], values: Array[Any]): java.util.Map[Any, Any] = { - import scala.collection.JavaConverters._ - keys.zip(values).toMap.asJava + Utils.toJavaMap(keys, values) } Review Comment: let me check this later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org