LuciferYang commented on code in PR #37876: URL: https://github.com/apache/spark/pull/37876#discussion_r971411597
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala: ########## @@ -129,20 +131,19 @@ object ArrayBasedMapData { def toScalaMap(map: ArrayBasedMapData): Map[Any, Any] = { val keys = map.keyArray.asInstanceOf[GenericArrayData].array val values = map.valueArray.asInstanceOf[GenericArrayData].array - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: Array[Any], values: Array[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: scala.collection.Seq[Any], values: scala.collection.Seq[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toJavaMap(keys: Array[Any], values: Array[Any]): java.util.Map[Any, Any] = { - import scala.collection.JavaConverters._ - keys.zip(values).toMap.asJava + Utils.toJavaMap(keys, values) } Review Comment: ~`ArrayBasedMapData#toJavaMap` is already a never used method, I think we can delete it, but need to confirm whether MiMa check can pass first~ EDIT: `ArrayBasedMapData#toJavaMap` not unused method, it used by `JavaTypeInference`, sorry, for missing what @mridulm said ########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ArrayBasedMapData.scala: ########## @@ -129,20 +131,19 @@ object ArrayBasedMapData { def toScalaMap(map: ArrayBasedMapData): Map[Any, Any] = { val keys = map.keyArray.asInstanceOf[GenericArrayData].array val values = map.valueArray.asInstanceOf[GenericArrayData].array - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: Array[Any], values: Array[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toScalaMap(keys: scala.collection.Seq[Any], values: scala.collection.Seq[Any]): Map[Any, Any] = { - keys.zip(values).toMap + Utils.toMap(keys, values) } def toJavaMap(keys: Array[Any], values: Array[Any]): java.util.Map[Any, Any] = { - import scala.collection.JavaConverters._ - keys.zip(values).toMap.asJava + Utils.toJavaMap(keys, values) } Review Comment: ~`ArrayBasedMapData#toJavaMap` is already a never used method, I think we can delete it, but need to confirm whether MiMa check can pass first~ EDIT: `ArrayBasedMapData#toJavaMap` not unused method, it used by `JavaTypeInference`, sorry for missing what @mridulm said -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org