HyukjinKwon commented on code in PR #38320:
URL: https://github.com/apache/spark/pull/38320#discussion_r1004094597
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala:
##########
@@ -26,4 +26,12 @@ private[spark] object Connect {
.intConf
.createWithDefault(15002)
+ val CONNECT_GRPC_INTERCEPTOR_CLASSES =
Review Comment:
That's what Hive thriftserver (separate module) dose. Avro (separate module)
and Kafka (separate module for Structured Streaming) do. Pandas API on Spark
also leverages runtime configurations via SparkSession under the hood instead
of SparkConf.
This is weird that it's a SQL thing uses SQL package namespace but it
doesn't use `SQLConf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
