cloud-fan commented on code in PR #38320: URL: https://github.com/apache/spark/pull/38320#discussion_r1004115757
########## connector/connect/src/main/scala/org/apache/spark/sql/connect/config/Connect.scala: ########## @@ -26,4 +26,12 @@ private[spark] object Connect { .intConf .createWithDefault(15002) + val CONNECT_GRPC_INTERCEPTOR_CLASSES = Review Comment: I'm not sure what's the benefit of doing so. Config definition can be anywhere and we can still use SQLConf to access it. e.g. `SQLConf.get.getConf(CONNECT_GRPC_INTERCEPTOR_CLASSES)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org