dongjoon-hyun commented on code in PR #38651:
URL: https://github.com/apache/spark/pull/38651#discussion_r1022306648
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotsStoreImpl.scala:
##########
@@ -94,7 +95,9 @@ private[spark] class ExecutorPodsSnapshotsStoreImpl(
override def stop(): Unit = {
pollingTasks.asScala.foreach(_.cancel(false))
- ThreadUtils.shutdown(subscribersExecutor)
+ // SPARK-41136: it may be called by MGR, and since that MGR has a default
30s timeout, here
Review Comment:
- In this case, we don't need JIRA id in the code.
- Please write full name instead of MGR.
- When MGR has non-default timeout like 20s, what happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
