dongjoon-hyun commented on code in PR #38651:
URL: https://github.com/apache/spark/pull/38651#discussion_r1023278795
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -723,6 +723,18 @@ private[spark] object Config extends Logging {
.checkValue(value => value > 0, "Maximum number of pending pods should
be a positive integer")
.createWithDefault(Int.MaxValue)
+ val KUBERNETES_EXECUTOR_SNAPSHOTS_SUBSCRIBERS_GRACE_PERIOD =
+
ConfigBuilder("spark.kubernetes.executorSnapshotsSubscribersShutdownGracePeriod")
+ .doc("Time to wait for graceful shutdown
kubernetes-executor-snapshots-subscribers " +
+ "thread pool. Since it may be called by ShutdownHookManager, where
timeout is " +
+ "controlled by hadoop configuration `hadoop.service.shutdown.timeout`
" +
+ "(default is 30s). As the whole Spark shutdown procedure shares the
above timeout, " +
+ "this value should be short than that to prevent blocking the
following shutdown " +
+ "procedures.")
+ .version("3.4.0")
+ .timeConf(TimeUnit.SECONDS)
Review Comment:
Please add `checkValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
