pan3793 commented on code in PR #38651:
URL: https://github.com/apache/spark/pull/38651#discussion_r1023756963
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala:
##########
@@ -103,7 +103,7 @@ private[spark] class KubernetesClusterManager extends
ExternalClusterManager wit
val subscribersExecutor = ThreadUtils
.newDaemonThreadPoolScheduledExecutor(
"kubernetes-executor-snapshots-subscribers", 2)
- val snapshotsStore = new
ExecutorPodsSnapshotsStoreImpl(subscribersExecutor)
+ val snapshotsStore = new ExecutorPodsSnapshotsStoreImpl(sc.conf,
subscribersExecutor)
Review Comment:
yes, but I prefer the SparkConf here, otherwise another
in-backward-compatibility constructor issue will happen if we pass other
parameters in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
