dengziming commented on code in PR #38659: URL: https://github.com/apache/spark/pull/38659#discussion_r1024865486
########## connector/connect/src/main/protobuf/spark/connect/relations.proto: ########## @@ -213,7 +213,7 @@ message Deduplicate { message LocalRelation { repeated Expression.QualifiedAttribute attributes = 1; Review Comment: I find we lack a `fromBatchWithSchemaIterator` method correspond to `toBatchWithSchemaIterator`, so I will implement one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org