HyukjinKwon commented on code in PR #38659: URL: https://github.com/apache/spark/pull/38659#discussion_r1028942760
########## core/src/main/scala/org/apache/spark/util/Utils.scala: ########## @@ -3257,6 +3257,14 @@ private[spark] object Utils extends Logging { case _ => math.max(sortedSize(len / 2), 1) } } + + def closeAll(closeables: AutoCloseable*): Unit = { Review Comment: I think this is too much to have it as a common util at the core module. It's only used twice .. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org